Page MenuHomePhabricator

Esanders (Ed Sanders)
Principal Software Engineer, Editing

Projects (19)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (278 w, 3 d)
Availability
Available
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Esanders claimed T246259: "Remember my last editor" should probably not change preference if only one editor was available in 2017WTE.
Thu, Feb 27, 4:28 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Editing-team (Q3 2019-2020 Kanban Board), VisualEditor-MediaWiki, VisualEditor

Wed, Feb 26

Esanders added a project to T235850: UI elements misaligned and misplaced: OOUI.

This is also affecting UploadWizard:

Wed, Feb 26, 9:58 PM · OOUI, Language-Team (Language-2020-January-March), ContentTranslation
Esanders added a comment to T245960: Late reply to early comment added in unexpected place in the discussion.
Wed, Feb 26, 8:27 PM · Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), DiscussionTools
Esanders renamed T246259: "Remember my last editor" should probably not change preference if only one editor was available in 2017WTE from "Remember my last editor" should probably not change preference if only one editor was available to "Remember my last editor" should probably not change preference if only one editor was available in 2017WTE.
Wed, Feb 26, 8:21 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Editing-team (Q3 2019-2020 Kanban Board), VisualEditor-MediaWiki, VisualEditor
Esanders created T246259: "Remember my last editor" should probably not change preference if only one editor was available in 2017WTE.
Wed, Feb 26, 7:06 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Editing-team (Q3 2019-2020 Kanban Board), VisualEditor-MediaWiki, VisualEditor
Esanders added a comment to T140606: Check user signature for linter errors.

As long as we allow {{subst}} in a signature, there is no reasonable way for us to continually validate that what is transcluded is balanced wikitext, therefore the only reasonable thing to do is to not allow any transclusions in signatures.

Wed, Feb 26, 4:59 PM · Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review, OWC2020, MediaWiki-extensions-Linter, MediaWiki-User-preferences

Tue, Feb 25

Esanders added a comment to T235593: Replies v2.0: create mockups.

What do you envision happening when someone selects the quote tool?

Tue, Feb 25, 3:55 PM · Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 2.0), Editing Design
Esanders added a comment to T235593: Replies v2.0: create mockups.

Re: placeholder text saying "Reply to @RockawayBch4vr"

  1. Is the '@' necessary?
  2. Should we show it for IPs, e.g. "Reply to 192.168.0.1" / "Reply to @192.168.0.1"
Tue, Feb 25, 3:52 PM · Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 2.0), Editing Design
Esanders added a comment to T245568: Highlighting (CodeMirror) changes the editor font from the user preference (sans/serif) to monospace.

It's just buggy.

Tue, Feb 25, 3:44 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Editing-team, MediaWiki-extensions-CodeMirror, Community-Tech
Esanders added a comment to T238218: Control whitespace in injected wikitext for multi-line comments.

(For this reply I'm assuming that the <span ...>...</span> is being saved directly into the wikitext, since this seems to be implied.)

Tue, Feb 25, 2:38 PM · OWC2020, Parsoid
Esanders updated the task description for T245772: Reply link is appearing for a signature inside a caption of an image on fr.wiki.
Tue, Feb 25, 2:20 PM · Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), DiscussionTools
Esanders added a comment to T245772: Reply link is appearing for a signature inside a caption of an image on fr.wiki.

Probably not, but I don't think this is that much of an issue. Social conventions dictate that the user just not use that reply link, in the same way they dictate that the original user probably shouldn't have signed inside the caption in the first place. As the product is based on unstructured input, there are always going to be unexpected outcomes like this is break with the conventions.

Tue, Feb 25, 2:20 PM · Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), DiscussionTools
Esanders added a comment to T245930: MultiMediaViewer: Various cleanup patches (tracking task).

Per a comment on gerrit, an example where auto-fixing needs manual review is the auto-indenting of block comments:

Tue, Feb 25, 2:17 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Patch-For-Review, Cleanup, MediaViewer
Esanders added a comment to T245789: Reply link is missing on some user talk pages on ar.wiki.

@matmarex's last comment is reference another ticket T246047 which is the same issue with French timestamps from before 2005. There may be others we don't know about, but unless there are very recent on non-tiny wikis we probably don't need to worry too much.

Tue, Feb 25, 2:06 PM · Editing-team, OWC2020 (OWC2020 Replying 1.0), DiscussionTools
Esanders added a comment to T240474: Performance review for the DiscussionTools extension.

I noticed a startup regression on nlwiki today. The extension currently registers 8 additional ResourceLoader modules which is more than the recommended maximum for new developments. It looks like it might only need two. Could you look into that meanwhile?

Tue, Feb 25, 1:58 PM · Patch-For-Review, Editing-team (Tracking), OWC2020 (OWC2020 Replying 1.0), Performance-Team, DiscussionTools
Esanders added a comment to T246047: Reply link is not appearing for a Project Talk page on fr.wiki.

Snap, Bartosz.

Tue, Feb 25, 1:05 AM · Editing-team (Tracking), DiscussionTools
Esanders added a comment to T246047: Reply link is not appearing for a Project Talk page on fr.wiki.

Those very old timestamp are using abbreviated month names (fév instead of février). I assume fr.wiki switch from short to long month names at some point in the past. Whether or not we try to fix this will probably depend on how long ago that was.

Tue, Feb 25, 1:00 AM · Editing-team (Tracking), DiscussionTools

Mon, Feb 24

Esanders added a comment to T245887: Consider changing default focus style (e.g. for links) to match WMUI.

Thanks. The box-shadow outset was the one I was experimenting with, and would probably be the best approach here.

Mon, Feb 24, 8:41 PM · Readers-Web-Backlog (Design), Accessibility, Vector
Iniquity awarded T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style a Love token.
Mon, Feb 24, 6:08 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Patch-For-Review, UI-Standardization, WikiEditor
Esanders moved T235761: Decide what to show when user is viewing an old version of a talk page from Needs Discussion / Investigation to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.
Mon, Feb 24, 3:53 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools, OWC2020
Esanders edited projects for T235761: Decide what to show when user is viewing an old version of a talk page, added: Editing-team (Q3 2019-2020 Kanban Board); removed Editing-team.
Mon, Feb 24, 3:52 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools, OWC2020
Esanders updated subscribers of T235761: Decide what to show when user is viewing an old version of a talk page.
Mon, Feb 24, 3:52 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools, OWC2020
Esanders moved T240643: Better handle edit conflicts (race conditions) in DiscussionTools from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.
Mon, Feb 24, 3:52 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), OWC2020 Replying 1.0, Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools
Esanders moved T245333: When you get an error while posting a reply, but eventually succeed, the reply is posted twice from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.
Mon, Feb 24, 3:51 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools
Esanders moved T245327: Better handle bad token errors (user logs in or out in another tab) in DiscussionTools from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.
Mon, Feb 24, 3:51 PM · Editing QA, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools
Esanders moved T245692: [Investigate] Why does parser detect a comment when a link to a person's user page, talk page or contributions page is missing. from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.
Mon, Feb 24, 3:33 PM · Editing QA, DiscussionTools, OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board)
Esanders added a comment to T245930: MultiMediaViewer: Various cleanup patches (tracking task).

Another issue I just noticed is that if you run fix as part of default then it will get run by default by CI and errors will not get detected.

Mon, Feb 24, 1:48 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Patch-For-Review, Cleanup, MediaViewer
Esanders moved T245579: The Reply tool removes pages from my watchlist from Ready for Development to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.
Mon, Feb 24, 1:39 PM · Patch-For-Review, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), DiscussionTools

Sun, Feb 23

Esanders added a comment to T245930: MultiMediaViewer: Various cleanup patches (tracking task).

In the past we have sometimes created a subtask for fix, then you can grunt eslint:fix but it might be nicer to use grunt.option('fix'):

Sun, Feb 23, 5:03 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Patch-For-Review, Cleanup, MediaViewer
Esanders added a comment to T245887: Consider changing default focus style (e.g. for links) to match WMUI.

I think the point here is to unify our focus styles, not create a new one. The proposal is to make the outline blue to match our existing focus styles in WMUI:

Sun, Feb 23, 3:37 PM · Readers-Web-Backlog (Design), Accessibility, Vector

Fri, Feb 21

Esanders created T245887: Consider changing default focus style (e.g. for links) to match WMUI.
Fri, Feb 21, 11:03 PM · Readers-Web-Backlog (Design), Accessibility, Vector
Esanders added a comment to T245568: Highlighting (CodeMirror) changes the editor font from the user preference (sans/serif) to monospace.

The reason we did this is because NWE uses ve.ce.Surface as the edit surface. This is where all our input support is coded, including things like RTL and IME support, which are more buggy in CodeMirror, and also things like inline inspectors (like the link inspector). The two surface approach is a workaround to allow us to keep using the ve.ce.Surface.

Fri, Feb 21, 7:35 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Editing-team, MediaWiki-extensions-CodeMirror, Community-Tech
Esanders claimed T245579: The Reply tool removes pages from my watchlist.
Fri, Feb 21, 4:19 PM · Patch-For-Review, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), DiscussionTools
Esanders created T245839: API warnings on VE save.
Fri, Feb 21, 3:48 PM · Regression, VisualEditor
Esanders added a comment to T207369: Embedded buttons in dialogs lack padding.

Monkey-patched the above into CX and the dialog correctly changed to vertical for English:

Fri, Feb 21, 3:14 PM · OOUI, ContentTranslation
Esanders added a project to T207369: Embedded buttons in dialogs lack padding: OOUI.
Fri, Feb 21, 2:43 PM · OOUI, ContentTranslation
Esanders added a comment to T207369: Embedded buttons in dialogs lack padding.

So it looks like we already do this:

Fri, Feb 21, 2:43 PM · OOUI, ContentTranslation
Esanders created T245832: Button text not vertically aligned properly.
Fri, Feb 21, 2:34 PM · OOUI, ContentTranslation
Esanders added a comment to T245539: Implement BetaFeatures integration.

Updated and tweaked slightly:

Fri, Feb 21, 1:14 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools
Esanders added a comment to T245539: Implement BetaFeatures integration.

The links are as I set them in the patch but without the hash link to #Active_initiatives. I'm not sure that's necessary at the moment given it's visible from the top of the page anyway. Also linking to sections is a bit flaky as they can often be reworded which breaks inbound links (unlike pages which leave behind redirects when they are moved).

Fri, Feb 21, 1:11 AM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools

Thu, Feb 20

Esanders added a comment to T245539: Implement BetaFeatures integration.

Created BF preference with provisional copy, can be easily tweaked:

Thu, Feb 20, 11:37 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools
Esanders moved T245539: Implement BetaFeatures integration from Doing to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.
Thu, Feb 20, 11:36 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools
Esanders moved T245539: Implement BetaFeatures integration from Ready for Development to Doing on the Editing-team (Q3 2019-2020 Kanban Board) board.
Thu, Feb 20, 8:34 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools
Esanders added a comment to T245694: Handle signatures within transcluded templates or "subpages".

Once we have modified the parser to detect subpages we could hide these links, but:

  1. Having done that we will be about 50% of the way to supporting subpage editing anyway and
  2. We can only detect subpages once the Parsoid HTML has finished loading in the background, so either the reply links would start enabled then disable some time later, or we would have to delay all reply links from showing until the Parsoid HTML has finished loading.
Thu, Feb 20, 4:07 PM · Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), DiscussionTools

Wed, Feb 19

Esanders updated the task description for T217023: Ensure all CSS selectors are prefixed.
Wed, Feb 19, 11:33 PM · Patch-For-Review, Technical-Debt, ContentTranslation
Esanders added a comment to T242562: Develop a technical approach for editing a specific comment.

We've started on an approach based on David's rebalancer, which can slice a reply tree into three balanced parts based on an arbitrary selection. We still need to work out how to handle the number of lines within a comment change works, and also how to keep the signature out of the edit range (T245220).

Wed, Feb 19, 5:05 PM · DiscussionTools, Editing-team (Q3 2019-2020 Kanban Board), OWC2020
Esanders added a comment to T245568: Highlighting (CodeMirror) changes the editor font from the user preference (sans/serif) to monospace.

Why is that so?

Wed, Feb 19, 4:00 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Patch-For-Review, Editing-team, MediaWiki-extensions-CodeMirror, Community-Tech
Esanders renamed T245532: 2017WTE + highlighting (CodeMirror) text layout is off by 1.5em on desktop Minerva from 2017WTE + highlighting (CodeMirror) text layout is off by 1.5em to 2017WTE + highlighting (CodeMirror) text layout is off by 1.5em on desktop Minerva.
Wed, Feb 19, 3:37 PM · User-Ryasmeen, Editing-team, CSS, MediaWiki-extensions-CodeMirror, Community-Tech, Patch-For-Review, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders updated subscribers of T245476: 2017WTE uses 13px font, while VE uses the skin's default.

I would rather we kept the same font-size between the various wikitext editors for now. There may be a case to increase it for serif, but that will affect a very small number of users who ever change that preference.

Wed, Feb 19, 3:36 PM · Editing-team, CSS, Patch-For-Review, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Tue, Feb 18

Esanders added a comment to T245476: 2017WTE uses 13px font, while VE uses the skin's default.

Unreadable 13px font-size.

Tue, Feb 18, 7:28 PM · Editing-team, CSS, Patch-For-Review, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Esanders added a comment to T245220: Comment parser should report range of comment and signature separately.

We discussed today possible approach for auto-detecting non-word characters. I think making too many characters editable is preferable to making too few characters editable so I would err on the side of only including characters we are sure belong in the signature, so probably just hard-coding -- to begin with, or doing nothing.

Tue, Feb 18, 7:17 PM · OWC2020 (OWC2020 Replying 2.0), Editing-team (Tracking), DiscussionTools

Thu, Feb 13

Esanders created T245220: Comment parser should report range of comment and signature separately.
Thu, Feb 13, 11:14 PM · OWC2020 (OWC2020 Replying 2.0), Editing-team (Tracking), DiscussionTools

Wed, Feb 12

Esanders added a comment to T238177: Create mockup for a new approach to previewing a reply.

I'm not a big fan of the big hockey-stick curve, as it doesn't match with our border radii elsewhere. I'd prefer either a sharp bend, a 2px curve, or something else we haven't thought of that doesn't require the line to turn.

Wed, Feb 12, 11:52 PM · OWC2020 (OWC2020 Replying 2.0), Editing Design, MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Editing-team (Q3 2019-2020 Kanban Board)
Esanders moved T242562: Develop a technical approach for editing a specific comment from Ready for Development to Doing on the Editing-team (Q3 2019-2020 Kanban Board) board.
Wed, Feb 12, 6:47 PM · DiscussionTools, Editing-team (Q3 2019-2020 Kanban Board), OWC2020
Esanders added a comment to T241090: Echo rendering issues on desktop Minerva, not usable on mobile.

Thanks @Jdlrobson

Wed, Feb 12, 5:23 PM · Growth-Team (Current Sprint), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MinervaNeue (Desktop), Notifications

Mon, Feb 10

Esanders added a comment to T242493: [Regression] Tooltip appears misaligned on mobile VE .

For testing, this also caused T242362, dropdowns not rendering correctly:

Mon, Feb 10, 7:53 PM · Verified, MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Regression
Esanders merged T242362: [Regression] None of the options under any drop down are visible on mobile VE into T242493: [Regression] Tooltip appears misaligned on mobile VE .
Mon, Feb 10, 7:52 PM · Verified, MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Regression
Esanders merged task T242362: [Regression] None of the options under any drop down are visible on mobile VE into T242493: [Regression] Tooltip appears misaligned on mobile VE .
Mon, Feb 10, 7:52 PM · VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Regression
Esanders added a comment to T242362: [Regression] None of the options under any drop down are visible on mobile VE .

I managed to reproduce this on Chrome (desktop + mobile emulation). The cause is the same as T242493.

Mon, Feb 10, 7:51 PM · VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Regression
Esanders awarded T76245: Create ability to trivially spin up MediaWiki instance of a particular patch/diff a Burninate token.
Mon, Feb 10, 7:30 PM · Developer Productivity, MediaWiki-Vagrant, Labs-Vagrant, MediaWiki-General

Sun, Feb 9

Rxy awarded T244595: Save button on Japanese Wikipedia is unnecessarily long a Like token.
Sun, Feb 9, 11:48 AM · I18n, VisualEditor, WikiEditor

Sat, Feb 8

Esanders added a comment to T241090: Echo rendering issues on desktop Minerva, not usable on mobile.

This caused a regression in VE: T242493

Sat, Feb 8, 12:32 AM · Growth-Team (Current Sprint), MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MinervaNeue (Desktop), Notifications
Esanders added a comment to T242493: [Regression] Tooltip appears misaligned on mobile VE .

Looks like the offending styles come from Echo and were introduced in T241090.

Sat, Feb 8, 12:32 AM · Verified, MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Regression
Esanders added a comment to T242493: [Regression] Tooltip appears misaligned on mobile VE .

The appears to break when the viewport drops below 720px, so likely caused by the DEVICE_WIDTH_TABLET styles.

Sat, Feb 8, 12:29 AM · Verified, MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Regression
Esanders removed a project from T244609: Parsoid times out when using VisualEditor to load the Contact list on OfficeWiki : VisualEditor.
Sat, Feb 8, 12:19 AM · Performance-Team (Radar), Editing-team (Tracking), Parsoid, Performance Issue

Fri, Feb 7

Esanders updated subscribers of T242477: [Regression] The alignment icons are missing inside Media Settings dialog when opening the dialog first time in a login session .

I can reproduce in 13.1.2 & 13.2. Each of these testing devices has a difference screen size, so more likely it is due to some sub-pixel computation.

Fri, Feb 7, 8:02 PM · VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Regression
Esanders merged T242803: [Regression] The icon to add a new image inside a gallery is missing for mobile VE when opening the dialog first time in a login session into T242477: [Regression] The alignment icons are missing inside Media Settings dialog when opening the dialog first time in a login session .
Fri, Feb 7, 8:01 PM · VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Regression
Esanders merged task T242803: [Regression] The icon to add a new image inside a gallery is missing for mobile VE when opening the dialog first time in a login session into T242477: [Regression] The alignment icons are missing inside Media Settings dialog when opening the dialog first time in a login session .
Fri, Feb 7, 8:01 PM · Regression, VisualEditor
Esanders added a comment to T242803: [Regression] The icon to add a new image inside a gallery is missing for mobile VE when opening the dialog first time in a login session.

The image icon to the left of the filename is also not showing. I'm going to assume that this is a duplicate of T242477

Fri, Feb 7, 8:00 PM · Regression, VisualEditor
Esanders updated subscribers of T232601: Provide a mechanism for in-surface autocomplete.

Yes, but if you type "@admin" all the results go away. This line in the filter is responsible:

Fri, Feb 7, 7:04 PM · OWC2020 (OWC2020 Replying 2.0), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review
Esanders moved T244109: Can't paste into an empty paragraph in VisualEditor from a specific page (in Chrome) from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.
Fri, Feb 7, 6:54 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Editing QA, Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, VisualEditor-CopyPaste, VisualEditor-MediaWiki
Esanders added a project to T244109: Can't paste into an empty paragraph in VisualEditor from a specific page (in Chrome): Editing-team (Q3 2019-2020 Kanban Board).
Fri, Feb 7, 6:54 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Editing QA, Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, VisualEditor-CopyPaste, VisualEditor-MediaWiki
Esanders created T244595: Save button on Japanese Wikipedia is unnecessarily long.
Fri, Feb 7, 6:38 PM · I18n, VisualEditor, WikiEditor
Esanders updated subscribers of T232601: Provide a mechanism for in-surface autocomplete.
  1. We appear to not include exact matches in the result list, nor do we do anything special with an exact match. This means if I type "@Ed" to metion user:ed, I get no options
  2. If I type one or more spaces after an exact match (e.g. "@Ed<space>") the autocomplete list re-appears. I initially claimed that typing a space should kill the autocomplete feature, but given that usernames can contain spaces this becomes more complicated, especially if we start including API results in the autocomplete. We may have to introduce logic to stop searching as soon as we get a combined results list (local + API) of zero results.
Fri, Feb 7, 1:45 AM · OWC2020 (OWC2020 Replying 2.0), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review

Thu, Feb 6

Esanders added a comment to T240474: Performance review for the DiscussionTools extension.

A better solution, however, would be to use a contenteditable element rather than a textarea, which has the native ability of auto-expanding without the need for any javascript. And only falling back to a JS-autoexpanded textarea for browsers that don't support contenteditable.

Thu, Feb 6, 11:43 PM · Patch-For-Review, Editing-team (Tracking), OWC2020 (OWC2020 Replying 1.0), Performance-Team, DiscussionTools
Demian awarded T238177: Create mockup for a new approach to previewing a reply a Like token.
Thu, Feb 6, 8:59 AM · OWC2020 (OWC2020 Replying 2.0), Editing Design, MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Editing-team (Q3 2019-2020 Kanban Board)
Esanders added a comment to T243044: Heading formats are not rendering when added as part of a comment using new reply workflow.

This is correct behaviour. Headings can't be placed in lists using pure wikitext.

Thu, Feb 6, 5:45 AM · DiscussionTools, OWC2020
Esanders added a comment to T232601: Provide a mechanism for in-surface autocomplete.

The current patch puts the autocomplete list right under the cursor's bounding box:

Thu, Feb 6, 5:40 AM · OWC2020 (OWC2020 Replying 2.0), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review
Esanders added a comment to T232003: Remove borders from toolbars in WMUI.

TODO: Remove border:0 overrides in various projects (VE mobile, Flow, DiscussionTools, CX?)

Thu, Feb 6, 12:13 AM · OOUI (OOUI-0.36.4), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Editing-team (Q3 2019-2020 Kanban Board), Editing Design, Design

Wed, Feb 5

Esanders updated the task description for T240474: Performance review for the DiscussionTools extension.
Wed, Feb 5, 11:18 PM · Patch-For-Review, Editing-team (Tracking), OWC2020 (OWC2020 Replying 1.0), Performance-Team, DiscussionTools
Esanders added a comment to T217215: Toggle state in WikiEditor toolbar is not obvious.

This is being resolved by T223155.

Wed, Feb 5, 10:44 PM · Accessibility, Design, WikiEditor
Esanders merged T217215: Toggle state in WikiEditor toolbar is not obvious into T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style.
Wed, Feb 5, 10:44 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Patch-For-Review, UI-Standardization, WikiEditor
Esanders merged task T217215: Toggle state in WikiEditor toolbar is not obvious into T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style.
Wed, Feb 5, 10:44 PM · Accessibility, Design, WikiEditor
Esanders moved T239966: [Pre-deployment testing] Retaining draft comments/replies from Upcoming to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.
Wed, Feb 5, 7:39 PM · User-Ryasmeen, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 2.0), DiscussionTools
Esanders edited projects for T239966: [Pre-deployment testing] Retaining draft comments/replies, added: Editing-team (Q3 2019-2020 Kanban Board); removed Editing-team (Tracking).

I noticed that currently if we type a comment/reply and click "cancel" and then open the reply box again, it retains the typed comment

Wed, Feb 5, 7:39 PM · User-Ryasmeen, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 2.0), DiscussionTools
Esanders added a comment to T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style.

I've separated the Apex & WMUI patches, so the first patch just applies the change from "Current" to "Monobook/Apex".

Wed, Feb 5, 1:48 AM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Patch-For-Review, UI-Standardization, WikiEditor
Esanders added a comment to T223155: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style.

@Volker_E I've fixed the arrows in this parent patch:

Wed, Feb 5, 12:59 AM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Patch-For-Review, UI-Standardization, WikiEditor
Esanders moved T214880: [Bug] On Firefox mobile editor textarea should auto-expand from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.
Wed, Feb 5, 12:05 AM · Editing QA, Editing-team (Q3 2019-2020 Kanban Board), Readers-Web-Backlog (Tracking), MobileFrontend

Tue, Feb 4

Esanders added a comment to T232003: Remove borders from toolbars in WMUI.

Like I've shared in T232003#5465798 it's not uncommon to have nothing in the format toolgroup and the dropdown indicator would be the only thing?

Tue, Feb 4, 1:43 AM · OOUI (OOUI-0.36.4), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Editing-team (Q3 2019-2020 Kanban Board), Editing Design, Design
Esanders added a comment to T240608: Standardise a control for switching diff types from side by side to inline/visual.

Is there any reason not to fold the code in VisualEditor into core and hook into it from VisualEditor?

Tue, Feb 4, 1:37 AM · Patch-For-Review, VisualEditor, Readers-Web-Backlog (Design), User-Jdlrobson, Core Platform Team Workboards (Clinic Duty Team), Desktop Improvements, Multi-Content-Revisions, Technical-Debt (RW-Tech-Debt)
Esanders updated subscribers of T244191: CX duplicates section segmentation logic.

This task is a follow-up to T234323:

Tue, Feb 4, 12:32 AM · CX-boost, Technical-Debt
Esanders created T244191: CX duplicates section segmentation logic.
Tue, Feb 4, 12:20 AM · CX-boost, Technical-Debt

Wed, Jan 29

Esanders updated the task description for T230685: Provide an alternate mapping for bad words.
Wed, Jan 29, 9:51 PM · Patch-For-Review, MediaWiki-extensions-UrlShortener
Esanders committed rECEX067c9559b251: Use ve.promiseAll (authored by Esanders).
Use ve.promiseAll
Wed, Jan 29, 8:36 PM

Jan 29 2020

Krinkle awarded T236210: Replace EasyDeflate with faster library a Orange Medal token.
Jan 29 2020, 4:04 AM · Performance-Team-publish, Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team (Radar)

Jan 27 2020

Amire80 awarded T149851: Handle visual diffing of table cell merges a Like token.
Jan 27 2020, 10:23 AM · VisualEditor-Tables, VisualEditor
Amire80 awarded T170074: Deleting column with sparse cells leaves behind CE cells that don't exist in model a Like token.
Jan 27 2020, 10:23 AM · VisualEditor-Tables, VisualEditor

Jan 16 2020

Esanders added a comment to T232003: Remove borders from toolbars in WMUI.

I think it would be more consistent to remove borders from all tool groups (except menus) by default, then if individual products have use cases to add them back in they can. We could even add an API for manual spacers.

Jan 16 2020, 7:31 PM · OOUI (OOUI-0.36.4), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Editing-team (Q3 2019-2020 Kanban Board), Editing Design, Design
Esanders added a comment to T237019: Spacing between icons and labels is too large in tablet mode.

We don't do uneven px distances in our interfaces, but try to orient on an 8px base (4px is ok, 6px should be the absolute exception).

Jan 16 2020, 1:45 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Design, MinervaNeue
Esanders added a comment to T237019: Spacing between icons and labels is too large in tablet mode.

In the vertical menu the horizontal spacing is less of an issue, but I wouldn't say it looks too cramped, it's probably just a case of what you are used to. I think the benefit of having a consistent guide for others to follow outweighs that preference, for example we use the same spacing in all other OOUI components:

Jan 16 2020, 1:32 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Design, MinervaNeue