I think this can skip QA. However as part of sign off we should confirm that all the PHP documentation is displaying on docs.wikimedia.org (for MobileFrontend, Vector and Popups)
Moving to upcoming on the assumption that T113095 happens first and is a precursor to estimating this.
Fri, Feb 21
Low stuff doesn't show up in backlog so adding tracking where it does.
@ovasileva I'm bumping up to high as the MobileFormatter seems to be running on CSS rather than HTML! This is bad - lead paragraph code should not be running on CSS (or potentially JS) - who knows what problems that could be causing!
@ovasileva important question that needs answer before Tuesday: currently when the new changes roll out we will be dropping support for showing the logo on older devices eg. Android 2, IE6-8. If we want to retain that support I need you to move this into needs more work with a comment. If this is fine you can resolve (or arrange a later QA of logos everywhere).
@ovasileva there is a new branch coming shortly (7 April 2020). This should be done before that date. At this point it should be low risk as we are simply removing unused code. If we could schedule this some time in March that would be splendid. I've moved to needs prioritization so that this doesn't get lost.
Thu, Feb 20
Wed, Feb 19
Assuming this is waiting analysis from a developer in our team so unassigning Olga.
@ovasileva the above patch is pretty straightforward and IMO risk free. Perhaps we can estimate tomorrow?
@Gilles we talked about this a while back in November. My understanding was this was a priority?
Waiting for a day or two worth of data before checking logstash and calling this resolved.
Check in with @alexhollender about the appropriate behaviour here - box shadow or no box shadow
^ needed from Alex. Apart from this purely technical
Tue, Feb 18
Anyone able to help me SWAT this today? I can't make the 4pm window. https://logstash.wikimedia.org/goto/a624d20343842ebd6f174bd7f6b842c3
This would mean that the place where the sub-template is rendered, an HTML (or text) parameter is used instead and the value set to to the expanded template. This could lead to better separation of concerns and better re-use
For third parties I suggest that when not defined a logo degrades to the site title just as it does on mobile. Many sysops will rejoice at no longer having to provide a logo.
Mon, Feb 17
Patch needs review from someone other than me.
Upstream bug found: https://bugs.chromium.org/p/chromium/issues/detail?id=1018581
I assume that alex (or Volker) is the best person to lead the analysis of this task.
I'm unable to replicate this exact workflow.
Can this ticket be resolved?
This should be live now.
At first I thought maybe... in which case I would expect to see more reports for wikis which added the infobox class to div elements that were not infoboxes however looking closely at the reports this is not the case. I instead see requests for strange URIs such as Famotidine/static/apple-touch/wikipedia.png and deleted pages such as 2044_Summer_Olympics, Jessica Garza, Magic Roundabout (Colchester
Sat, Feb 15
This is unbreak now since yesterday and sounds like we are on the hook so I'm moving to the kanbanana board for further investigation.
Current special:mobilediff creates a lot of problems for users.)
And desktop has traditionally causes a lot of problems for mobile users so that's why we are in this situation.
Fri, Feb 14
Having said that, moving it (within core) to a different primitive seems fine. Based on the mock up, it looks like the proposal is to make the element a Page indicator, this is the same position we use for the "Help" icons shown on some special pages.
I don't think that is the plan.
The patch in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/571573/ causes alignment issues:
I've replied on the ticket.
@Ladsgroup any chance you could help me get rid of the rule in https://fa.m.wikipedia.org/wiki/%D9%85%D8%AF%DB%8C%D8%A7%D9%88%DB%8C%DA%A9%DB%8C:Mobile.css
Can a wrapping container be used?
For history this was added here: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/commit/677aa8935ff497674265f2581accc25487d4a977
I didn't see any reason not to remove it at this point.
I think this can skip QA - it's on https://doc.wikimedia.org/mediawiki-skins-Vector/master/js/js/ but I think we should verify that all the jsdocumented code is showing up there before sign off.
Thanks @Jdforrester-WMF I was off last 2 days. I can pickup the issue from here since I caused it.