Page MenuHomePhabricator

Schnark (Michael M.)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 7:11 AM (276 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Schnark [ Global Accounts ]

Recent Activity

Yesterday

Schnark renamed T243606: Inserting a table breaks CodeMirror highlighting in NWE from Firefox: Inserting a table breaks CodeMirror highlighting in NWE to Inserting a table breaks CodeMirror highlighting in NWE.
Sat, Jan 25, 9:08 AM · Community-Tech, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror
Schnark added a comment to T243606: Inserting a table breaks CodeMirror highlighting in NWE.

I can reproduce the same issue in Chromium, so this isn't Firefox specific. The highlight can be fixed by disabling CodeMirror and enabling it again, so it must be something weird that only happens during insertion.

Sat, Jan 25, 9:07 AM · Community-Tech, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror

Mon, Jan 13

Schnark closed T239888: Flash of unstyled content (FOUC) in diff views as Invalid.

I have tried to reproduce this with Firefox but could not; and since apparently no one reported this happening in over a month, I think this bug is invalid.

Mon, Jan 13, 8:13 AM · Browser-Support-Firefox, MediaWiki-Interface, MediaWiki-Page-Diffs

Thu, Jan 9

Schnark added a comment to T242327: QINU appears instead of math in search results.

Given that searching for QINU without math shows up results, too, this probably isn't Math specific: https://de.wikipedia.org/w/index.php?sort=relevance&search=QINU+-postMath&title=Spezial:Suche&profile=advanced&fulltext=1&advancedSearch-current=%7B%7D&ns0=1

Thu, Jan 9, 11:22 AM · Discovery-Search, MediaWiki-Parser, Math

Wed, Jan 8

Schnark added a comment to T237190: style="overflow:auto" should be applied directly to the <source>.

The idea is to omit the style="overflow:auto", which now doesn't do anything useful.

Wed, Jan 8, 8:01 AM · User-TheDJ, MediaWiki-Page-editing, SyntaxHighlight

Fri, Jan 3

Schnark added a comment to T154329: NWE and VE should be able to get fully loaded even if the browser tab is not active.

As far as I understand this actually is caused by MediaWiki-ResourceLoader: It uses requestAnimationFrame to add CSS styles, but using requestAnimationFrame in a background tab can be delayed for a long time. ("The callback rate may be reduced to a lower rate when running in background tabs" MDN) Thus the execution of depending modules may be delayed until you bring that tab into foreground again.

Worst now: MDN indicates “requestAnimationFrame() calls are paused in most browsers when running in background tabs or hidden <iframe>s in order to improve performance and battery life.”. 😢

Fri, Jan 3, 8:23 AM · Performance-Team (Radar), Performance Issue, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Mon, Dec 30

Schnark merged T203638: Different widths in NWE+CodeMirror can cause text and color to fall out of sync into T198278: [Regression ?] The text typed on the first line while adding a new section is blurry on Firefox.
Mon, Dec 30, 8:48 AM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), VisualEditor (Current work), Browser-Support-Firefox, MediaWiki-extensions-CodeMirror
Schnark merged task T203638: Different widths in NWE+CodeMirror can cause text and color to fall out of sync into T198278: [Regression ?] The text typed on the first line while adding a new section is blurry on Firefox.
Mon, Dec 30, 8:48 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror

Dec 20 2019

Schnark created T241221: Preview of reply uses wrong page name.
Dec 20 2019, 10:08 AM · Verified, VisualEditor (Current work), MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), OWC2020
Schnark added a comment to T241193: Replies with <gallery>...</gallery> tags do not render in preview properly.

You need to add modules to the prop parameter. Then the result will contain something like "modulestyles": ["mediawiki.page.gallery.styles"], which is the module you need to load to get the missing CSS.

Dec 20 2019, 10:08 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020

Dec 16 2019

Schnark added a comment to T208188: RFC: Partial opt-out method for Content security policy.

Should it be possible to add a short comment to the exceptions? Otherwise, users will ask themselves why they added an exception several years ago and wonder if they still use it. So I think it would make sense to allow adding a short comment like "exception for script foo" along with the exception.

Dec 16 2019, 8:15 AM · Core Platform Team, Patch-For-Review, ContentSecurityPolicy, TechCom-RFC, TechCom, Security-Team, Security

Dec 11 2019

matmarex awarded T229307: Reference numbers wrong in Firefox when following a list a Manufacturing Defect? token.
Dec 11 2019, 1:42 PM · User-Ryasmeen, WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Cite, WMDE-QWERTY-Sprint-2019-11-20, Upstream, VisualEditor, VisualEditor-MediaWiki-References, Browser-Support-Firefox
Schnark added a comment to T240327: Browser spellchecking broken in VE for words with special characters.

Now at https://bugzilla.mozilla.org/show_bug.cgi?id=1602526, so this definitely is a bug in Firefox, not in VE. Do we keep upstream bugs open here until they are fixed?

Dec 11 2019, 11:23 AM · VisualEditor
Schnark added a comment to T240327: Browser spellchecking broken in VE for words with special characters.

I now opened https://bugzilla.mozilla.org/show_bug.cgi?id=1603057

Dec 11 2019, 10:24 AM · VisualEditor
Schnark added a comment to T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff).

My only involvement with VisualDiffs is my user script https://de.wikipedia.org/wiki/Benutzer:Schnark/js/diff which hooks into the UI of VisualDiffs. I don't know who in the VE team currently feels responsible for the diffs, if there is anyone at all.

Dec 11 2019, 8:33 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Jdlrobson, Desktop Improvements, TechCom, MobileFrontend (MobileFrontend Special Pages), Multi-Content-Revisions, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt)
Schnark added a comment to T240327: Browser spellchecking broken in VE for words with special characters.

The DOM has just the plain text (and as far as I can tell there are no invisible format characters, either). The funny thing is: When I copy the affected HTML from VE to another contenteditable page, the spellchecking is broken there, too, even for newly entered text, but only inside the copied list item, not in new ones like it happens in VE.
So this might well be a bug in Firefox, and VE just more easily triggers it than a plain contenteditable. I'll try to investigate further and report it upstream if it turns out that the issue is not in VE.

Dec 11 2019, 8:25 AM · VisualEditor

Dec 10 2019

Schnark created T240327: Browser spellchecking broken in VE for words with special characters.
Dec 10 2019, 9:44 AM · VisualEditor
Schnark added a comment to T240259: Implement `unload handlers` for compose.

See https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw-method-confirmCloseWindow

Dec 10 2019, 8:19 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), VisualEditor (Current work), Editing-team, OWC2020
Schnark added a comment to T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff).

Just to clarify, what I could imagine as UI for diff switching, that would probably work well with VisualDiffs, is this:

Dec 10 2019, 8:11 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Jdlrobson, Desktop Improvements, TechCom, MobileFrontend (MobileFrontend Special Pages), Multi-Content-Revisions, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt)

Dec 9 2019

Schnark added a comment to T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff).

This uses diff-type as URL parameter, while VisualDiff uses diffmode. I think it makes sense to decide on one common interface for different diffs -- both for URL parameters and for UI to switch between different diff styles -- before graduating any of them out of beta.

Dec 9 2019, 9:18 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Jdlrobson, Desktop Improvements, TechCom, MobileFrontend (MobileFrontend Special Pages), Multi-Content-Revisions, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt)

Dec 6 2019

Daimona awarded T75714: ResourceLoader JavaScript parser should allow ES6 syntax features a Mountain of Wealth token.
Dec 6 2019, 4:42 PM · Performance-Team, MediaWiki-ResourceLoader

Dec 5 2019

Schnark created T239888: Flash of unstyled content (FOUC) in diff views.
Dec 5 2019, 8:15 AM · Browser-Support-Firefox, MediaWiki-Interface, MediaWiki-Page-Diffs

Dec 2 2019

Schnark added a comment to T239550: Copying multiple categories from the bottom of Wikipedia articles and pasting them into source editor (while logged in) breaks all pasting until you switch editors.

This works for me without any issues, both with the HotCat gadget enabled (as seen on the screenshots) and without it.

Dec 2 2019, 9:55 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Patch-For-Review, VisualEditor (Current work), VisualEditor-CopyPaste, VisualEditor-MediaWiki, MediaWiki-Categories

Nov 23 2019

Schnark added a comment to T238865: [[MediaWiki:Visualeditor-align-desc-center/da]] translation issue.

Link for those who don't have visual diffs enabled: https://test.wikipedia.org/w/index.php?title=User:Matma_Rex/sandbox&diff=409254&oldid=384621&diffmode=visual&visualdiff=1

Nov 23 2019, 8:40 AM · User-Ryasmeen, VisualEditor, I18n

Nov 15 2019

Schnark added a comment to T153434: Consider using colour/etc. to denote that tabs displayed as arrows / newlines as returns are not the raw Unicode character.

As noted on the merged patch, according to https://caniuse.com/#feat=mdn-css_properties_tab-size Firefox still needs the prefixed property -moz-tab-size.

Nov 15 2019, 8:33 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor (Current work), Design, VisualEditor-MediaWiki, VisualEditor-MediaWiki-2017WikitextEditor

Nov 11 2019

Schnark added a comment to T237688: Raise MW JS requirement to include ES6 Promise (drop IE11, Safari 5-6, and Android 4.1-4.3).

Are we already bikeshedding over which polyfill to use? If so, https://github.com/taylorhakes/promise-polyfill is much smaller than https://github.com/stefanpenner/es6-promise.

The size difference is quite significant. Do we know why the other one is so much larger? Is it missing something?

Nov 11 2019, 9:40 AM · Patch-For-Review, Browser-Support-Android-Google-Chrome, Browser-Support-Apple-Safari, MediaWiki-ResourceLoader, JavaScript, Browser-Support-Internet-Explorer, Performance-Team

Nov 8 2019

Schnark added a comment to T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.

Perhaps it is just enough to limit the selector to .mw-changeslist .mw-changeslist-date:before.

Nov 8 2019, 9:31 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes
Schnark created T237716: Editing old version shows two warnings in VE/NWE.
Nov 8 2019, 9:22 AM · VisualEditor
Schnark added a comment to T237688: Raise MW JS requirement to include ES6 Promise (drop IE11, Safari 5-6, and Android 4.1-4.3).

Are we already bikeshedding over which polyfill to use? If so, https://github.com/taylorhakes/promise-polyfill is much smaller than https://github.com/stefanpenner/es6-promise.

Nov 8 2019, 9:15 AM · Patch-For-Review, Browser-Support-Android-Google-Chrome, Browser-Support-Apple-Safari, MediaWiki-ResourceLoader, JavaScript, Browser-Support-Internet-Explorer, Performance-Team
Schnark updated the task description for T237611: RC: strange format of [sichten] link in recent changes.
Nov 8 2019, 8:55 AM · Wiktionary, Growth-Team, MediaWiki-Recent-changes
Schnark added a comment to T237190: style="overflow:auto" should be applied directly to the <source>.

As far as I understand, the religious fights are mostly about whether pre should allow manual breaks only, or whether browsers may break lines when too long. Since the core CSS already sets white-space: pre-wrap; for pre, .mw-code, this fight is over, and allowing breaks inside words when necessary shouldn't be much controversial.
On the other hand, this means that there should be only very few code blocks that currently overflow anyway. So I can't imagine that this change could have any real influence on any Wikipedia community using or rejecting code examples.

Nov 8 2019, 8:47 AM · User-TheDJ, MediaWiki-Page-editing, SyntaxHighlight
Schnark added a comment to T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.

Instance of multiple extra semicolon/spaces appearing: history view that include a deleted version:

Nov 8 2019, 8:19 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, MediaWiki-Watchlist, MediaWiki-Page-History, I18n, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions, Growth-Team, UI-Standardization, MediaWiki-Interface, MediaWiki-Recent-changes

Nov 7 2019

Schnark closed T237611: RC: strange format of [sichten] link in recent changes as Resolved.

This will be fixed by https://gerrit.wikimedia.org/r/549113, too.

Nov 7 2019, 10:28 AM · Wiktionary, Growth-Team, MediaWiki-Recent-changes
Schnark added a comment to T157956: NWE: Copying tab/newline characters using mouse only (on unixoid systems) doesn't work as expected.

This only fixes pastes inside VE, not into external applications, does it? And these are probably not fixable at all?

Nov 7 2019, 10:15 AM · VisualEditor (Current work), MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor

Nov 6 2019

Schnark added a comment to T213778: Update link colors in Vector for improved UX (and consistency).

There are actually more inconsistencies that could and should be addressed:

  • External links and interwiki links currently use #36c as color, and #636 when visited. But in edit comments (where only interwiki links may occur) they use the normal link colors instead. This means, currently they are barely distinguishable from internal links, not distinguishable at all in edit comments, and won't be distinguishable after the proposed update, except when visited. I actually don't really see the point in having different colors for them at all (for external links the icon after the link should be enough), so it might be best to remove all those special colors and use the proposed ones for all links. But in any case, the colors for these links really should be addressed here, too.
  • Active links (i.e. while you click on them) use #faa700, which has a very poor contrast ratio. Except for external links, which use #b63. (This is also the case for interwiki links, though they have an additional definition with yet another color, but that's overridden a few lines later.) And except for some (but not all) interface links, which don't have a special color. And except for links to missing pages, which don't have a special color for active links, either.
  • While we are at it: Links to missing pages use #ba0000, and #a55858 when visited. Except when the missing link is in a vector tab (e.g. link to missing talk page), there always #a55858 is used, even for links not visited.
Nov 6 2019, 9:55 AM · Readers-Web-Backlog (Design), Desktop Improvements, UI-Standardization, Vector
Schnark added a comment to T154977: NWE encodes linebreaks as \r\n but post-Parsoid wikitext is \n.

Is this browser depended? I still can reproduce with Firefox. E.g. on https://de.wikipedia.org/wiki/Benutzer:Schnark?veaction=editsource the above code logs 39.

Nov 6 2019, 8:04 AM · Skipped QA, VisualEditor (Current work), MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), VisualEditor-MediaWiki-2017WikitextEditor

Nov 5 2019

Dvorapa awarded T162337: Document hooks fired by VE via mw.hook a The World Burns token.
Nov 5 2019, 7:56 PM · VisualEditor-MediaWiki, Documentation, VisualEditor

Nov 2 2019

Schnark added a comment to T65060: Parsoid should not replace namespace aliases by other translations.

Now I found the recently created and fixed T237040: Visual editor changing automatically something in text while saving. Can we assume that after that change currently no automatic replacement happens, and that this issue can be closed, too, even if the original cause might have been different?

Nov 2 2019, 10:33 AM · Parsoid, I18n, Parsoid-Tokenizer
Schnark added a comment to T65060: Parsoid should not replace namespace aliases by other translations.

This happened in dewiki: https://de.wikipedia.org/w/index.php?title=Totengr%C3%A4ber_(K%C3%A4fer)&type=revision&diff=193594417&oldid=191699592
And the funny thing is that some users can reproduce it, and some can't, and sometimes the behaviour just changes. When I tested a few days ago, VE/Parsoid changed every Bild ("Image") to Datei ("File"), but when I tested again today, no such automatic changes occurred, even with the same edits in the same articles.

Nov 2 2019, 10:04 AM · Parsoid, I18n, Parsoid-Tokenizer
Schnark added a comment to T235852: Enable ResourceLoader module storage on Firefox 69+.

If I understand https://bugzilla.mozilla.org/show_bug.cgi?id=1592136 correctly, this has been reverted temporarily in FF 70.0.1.

Nov 2 2019, 9:00 AM · User-Michael, Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team, JavaScript

Oct 25 2019

Schnark created T236460: Regression: Changes to email blacklist or muted users do not activate Save button in Preferences.
Oct 25 2019, 7:06 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, Notifications, Growth-Team, MediaWiki-User-preferences

Oct 23 2019

Schnark merged T236228: If an image file is used multiple times within a page; MediaViewer always opens the first reference to it into T64039: MediaViewer confuses different instances of the same image on the same page.
Oct 23 2019, 7:01 AM · Multimedia, Patch-For-Review, MediaViewer
Schnark merged task T236228: If an image file is used multiple times within a page; MediaViewer always opens the first reference to it into T64039: MediaViewer confuses different instances of the same image on the same page.
Oct 23 2019, 7:01 AM · MediaViewer

Oct 22 2019

Ladsgroup awarded T219604: Remove unused jquery.ui.* and jquery.effects.* modules a Love token.
Oct 22 2019, 9:57 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.35-release, Performance-Team, MediaWiki-General, Technical-Debt (Deprecation process), JavaScript
Schnark merged T236128: formatversion=2 swallows up spaces sometimes on line breaks into T201946: Paragraph breaks returned by text API requests have changed.
Oct 22 2019, 9:10 AM · Readers-Web-Backlog (Tracking), TextExtracts, MediaWiki-API
Schnark merged task T236128: formatversion=2 swallows up spaces sometimes on line breaks into T201946: Paragraph breaks returned by text API requests have changed.
Oct 22 2019, 9:10 AM · Core Platform Team, MediaWiki-API
Schnark added a comment to T236128: formatversion=2 swallows up spaces sometimes on line breaks.

This has nothing to do with formatversion=2.

Oct 22 2019, 9:10 AM · Core Platform Team, MediaWiki-API

Oct 17 2019

Schnark added a comment to T218339: Deprecate and remove mediawiki.RegExp.

As of now, enwiki alone contains more than 200 usages, dewiki about 20.

Oct 17 2019, 9:59 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.35-release, MediaWiki-General, Performance-Team, Technical-Debt (Deprecation process)

Oct 16 2019

Schnark created T235609: Revert notification send to user who just protected a page.
Oct 16 2019, 8:57 AM · Notifications, Growth-Team
Schnark added a comment to T235603: Interface of Special:Contributions with toggle issue.

This looks like T234023, so check your local CSS if there is something like

.mw-collapsible-toggle {
    text-align: right;
}
Oct 16 2019, 8:40 AM · MW-1.34-release, MediaWiki-Special-pages
Schnark added a comment to T233823: Mobile VE edit flow: instrumentation post-deployment data checks.

review-initial-schnark

For that first one, @Schnark is a contributor and may have been doing something with gadgets or userscripts to trigger that.

Oct 16 2019, 7:15 AM · Product-Analytics (Kanban), VisualEditor (Current work)

Oct 15 2019

Schnark added a comment to T235457: Combine the user.tokens and user.options modules.

https://www.mediawiki.org/wiki/ResourceLoader/Core_modules#user.options states: "This module is loaded asynchronously and may depend on a separate HTTP request for the user.defaults module. Always declare the relevant dependencies for your module, or use mw.loader.using()." Assuming this is still true and won't be changed, setting the state of user.options to ready immediately might break scripts.

Oct 15 2019, 9:42 AM · MediaWiki-ResourceLoader, Performance-Team

Oct 14 2019

Schnark added a comment to T235319: Gray background FOUC on search icon.

As far as I can see, the gray is the default background color for buttons, so depending on browser and OS the issue might not be visible. But for me this happens both with Firefox, Chromium, and Konqueror on Linux.

Oct 14 2019, 8:08 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-Interface, Regression, Vector

Oct 12 2019

Schnark created T235319: Gray background FOUC on search icon.
Oct 12 2019, 8:35 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MediaWiki-Interface, Regression, Vector
Schnark added a comment to T234404: Write a comment parser for PHP HTML.

Oh, and I just want to say that I admire the magic with perfectly chosen default values that makes the parser even correctly detect signatures by users that only link to their talk page and sign on that talk page. Even though this doesn't generate a real link, the parser works as expected.

Oct 12 2019, 8:21 AM · VisualEditor (Current work), Editing-team, OWC2020

Oct 11 2019

Schnark closed T235248: mw.user.tokens.get('editToken') returns null as Invalid.

editToken has been deprecated for years and removed recently. See T234576 and use csrfToken instead.

Oct 11 2019, 8:05 AM
Schnark added a comment to T235226: List editing buggy in VE when using templates as list entries.

I think this is T55368: Several issues with templated list items.

Oct 11 2019, 7:49 AM · VisualEditor

Oct 10 2019

Schnark added a comment to T234404: Write a comment parser for PHP HTML.
  • I see that there is code for local timezone abbreviations, but it doesn't seem to work: On https://de.wiktionary.org/wiki/Wiktionary:Auskunft (and other pages on de.wikt), which uses MEZ and MESZ instead of CET and CEST, no signatures are found.
  • Even minor variations in the timestamp format make the parser fail, e.g. deleting a leading 0 in the hour, missing period after abbreviated month, etc. These variations sometimes happen when a missing or wrong signature is fixed manually afterwords, and for old comments (seems like back in 2006 the format was a little different, which of course isn't a real problem, but probably means the parser will break when the timestamp format is changed again).
  • When the name of the user comes after the timestamp, the parser doesn't find it (uncommon, happens mostly when you accidentally click twice to insert 8 tildes instead of 4, https://de.wikipedia.org/wiki/Diskussion:Stra%C3%9Fenbahn_Berlin#Pl%C3%A4ne_f%C3%BCr_Neubaustrecken)
  • It's not clear what will happen when a comment has 2 timestamps (E.g. "See my previous comment on <old timestamp> --User <new timestamp>", or "Comment -- User <first timestamp>, modified <second timestamp>"), or even 2 signatures.
Oct 10 2019, 9:12 AM · VisualEditor (Current work), Editing-team, OWC2020

Oct 9 2019

Schnark updated subscribers of T234888: Tab to search after article loaded no longer works.

According to T226148: Remove `tabindex="1"` from #simpleSearch this was intentional.

Oct 9 2019, 7:50 AM · Vector, MediaWiki-Interface, Regression

Oct 4 2019

Schnark added a comment to T234404: Write a comment parser for PHP HTML.

Depending on what exactly the requirements are, you probably want to have a look at includes/DiscussionParser.php from Echo (and perhaps old versions of that code to see what alternatives there are and why they don't work).

Oct 4 2019, 8:06 AM · VisualEditor (Current work), Editing-team, OWC2020

Sep 28 2019

Schnark added a comment to T226148: Remove `tabindex="1"` from #simpleSearch.

Is the dependency on jquery.tabIndex used anywhere else? If not, this can be removed, too.

Sep 28 2019, 8:41 AM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Readers-Web-Backlog (Tracking), Vector, Accessibility

Sep 27 2019

Schnark added a comment to T234023: New page history filter dropdown on zh-yue wiki shows truncated "Expand" label string; "Filter revisions" string on other side.

This is caused by local CSS:

.mw-collapsible-toggle {
    text-align: right;
}

(https://zh-yue.wikipedia.org/wiki/MediaWiki:Common.css)

Sep 27 2019, 9:35 AM · Reading-Web-Local-Wiki-Issues, MediaWiki-Page-History
Schnark created T234017: Protect log entries offer link to change protection only to unprivileged users.
Sep 27 2019, 8:36 AM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MediaWiki-Logging, Regression

Sep 17 2019

Schnark added a comment to T227564: Menu of DropdownWidget with $overlay has padding at bottom.

BTW, this doesn't happen for $overlay: true (and the code where I used the body as overlay predates the default overlay), so there is an easy workaround.

Sep 17 2019, 7:56 AM · OOUI

Sep 14 2019

Schnark added a comment to T232601: Provide a mechanism for in-surface autocomplete.

I have a script for autocomplete suggestions (not for @user, but for words already in the text): https://de.wikipedia.org/wiki/Benutzer:Schnark/js/veSuggestions.js
(German) documentation (including screenshot) is on https://de.wikipedia.org/wiki/Benutzer:Schnark/js/veSuggestions
If you want to reuse any code from there, feel free to do so.

Sep 14 2019, 9:40 AM · Patch-For-Review, OWC2020, VisualEditor (Current work)

Sep 9 2019

Schnark updated subscribers of T232285: How to use Babel.js with MediaWiki Javascript.

With a PHP port of babel.js (or some wrapper) this should be possible in theory, but:

Sep 9 2019, 7:25 AM · MediaWiki-ResourceLoader, Performance-Team

Aug 23 2019

Schnark added a comment to T231031: Instrument usage of ISBN barcode scanner.

what sort of things they scan (presumably: 99.9% books, but let's confirm that)

The tool only reads ISBNs, which stands for International Standard Book Number[0], so...

Aug 23 2019, 7:05 AM · VisualEditor (Current work), Citoid

Aug 20 2019

Schnark created T230782: Link list on ApiSandbox looks silly.
Aug 20 2019, 10:07 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Schnark closed T135489: Special:Contributions in newbie mode shouldn't use old definition of newbie as Declined.

Feature removed with T220447: Split out or remove Special:Contributions/newbies functionality.

Aug 20 2019, 9:43 AM · MediaWiki-Special-pages

Aug 16 2019

Schnark added a comment to T181484: Links to sections in an article will land behind unscrollable header in older browsers.

According to https://caniuse.com/#feat=css-snappoints this should also work in Safari (which I didn't test), and it will work in Edge once they switch to Blink.

Aug 16 2019, 7:16 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Timeless

Aug 13 2019

Schnark added a comment to T230395: Unreachable item in a long list outside of the bodycontent div.

See T182602 and https://www.mediawiki.org/wiki/OOUI/Concepts#Overlays.

Aug 13 2019, 9:48 AM · WikibaseMediaInfo, UploadWizard
Schnark created T230393: Arrow in DateInputWidget vanishes on hover.
Aug 13 2019, 7:26 AM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MediaWiki-General

Aug 6 2019

Schnark added a comment to T226476: wgUserNewMsgRevisionId is null even when there are new messages.

BTW, this also happens for users not logged in (though I'm not entirely sure whether the variable should be set in for those users, too, but I don't see a reason why not).

Aug 6 2019, 7:02 AM · MediaWiki-General

Aug 5 2019

Schnark updated subscribers of T229734: Convert button doesn't display since wmf.16.

Since this works in mobile editor, I'm going to blame rECEX46014698791a: Move convert ref button to footer when the footer exists (even though that is wmf.16, not wmf.15).

Aug 5 2019, 7:31 AM · Skipped QA, VisualEditor (Current work), Citoid
Schnark created T229781: Editing fails when section is deleted.
Aug 5 2019, 7:19 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
Schnark added a project to T229734: Convert button doesn't display since wmf.16: Citoid.
Aug 5 2019, 7:05 AM · Skipped QA, VisualEditor (Current work), Citoid

Aug 2 2019

Schnark added a comment to T229592: citoid dosen't work at Hindi Wikipedia.

The console shows the following warning:

Aug 2 2019, 7:21 AM · User-Ryasmeen, VisualEditor, Citoid

Aug 1 2019

Schnark added a comment to T229467: Investigate how visual diffs differ performance can be optimized .

A cheap “fix” that might be worth investigating is seeing whether we can pack the entire thing into a Web Worker (what’s a web worker?), thus getting it off the main thread even if it doesn’t speed it up in any way.

Aug 1 2019, 7:28 AM · VisualEditor (Current work)
Schnark added a comment to T229307: Reference numbers wrong in Firefox when following a list.

And now I found https://bugzilla.mozilla.org/show_bug.cgi?id=1545746, which already is closed as invalid.

Aug 1 2019, 7:17 AM · User-Ryasmeen, WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Cite, WMDE-QWERTY-Sprint-2019-11-20, Upstream, VisualEditor, VisualEditor-MediaWiki-References, Browser-Support-Firefox

Jul 31 2019

Schnark merged T229373: For some HTML entities, the edit preview incorrectly shows the interpreted value (e.g. "[") but the saved edit shows "&lbrack;" into T94603: Unexpanded HTML character entity references.
Jul 31 2019, 8:00 AM · MediaWiki-Parser
Schnark merged task T229373: For some HTML entities, the edit preview incorrectly shows the interpreted value (e.g. "[") but the saved edit shows "&lbrack;" into T94603: Unexpanded HTML character entity references.
Jul 31 2019, 8:00 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Schnark added a comment to T229307: Reference numbers wrong in Firefox when following a list.

After reading https://drafts.csswg.org/css-lists-3/#list-item-counter: This might actually be the expected behavior (but I'm not going to encourage Firefox devs by making that comment on Bugzilla), and the correct workaround is counter-reset: mw-ref-linkback list-item.

Jul 31 2019, 7:14 AM · User-Ryasmeen, WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Cite, WMDE-QWERTY-Sprint-2019-11-20, Upstream, VisualEditor, VisualEditor-MediaWiki-References, Browser-Support-Firefox

Jul 30 2019

Schnark added a comment to T229307: Reference numbers wrong in Firefox when following a list.

I was able to reduce it to a minimal example, and reported this upstream as https://bugzilla.mozilla.org/show_bug.cgi?id=1569886.

Jul 30 2019, 7:51 AM · User-Ryasmeen, WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Cite, WMDE-QWERTY-Sprint-2019-11-20, Upstream, VisualEditor, VisualEditor-MediaWiki-References, Browser-Support-Firefox
Schnark created T229307: Reference numbers wrong in Firefox when following a list.
Jul 30 2019, 7:30 AM · User-Ryasmeen, WMDE-QWERTY-Sprint-2019-12-11, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Cite, WMDE-QWERTY-Sprint-2019-11-20, Upstream, VisualEditor, VisualEditor-MediaWiki-References, Browser-Support-Firefox

Jul 19 2019

Schnark added a comment to T228353: Consider expanding wikilink search results.

Wikilinks already included within the article

Jul 19 2019, 7:31 AM · VisualEditor-MediaWiki-Mobile, VisualEditor

Jul 17 2019

Schnark added a comment to T225021: Support a new "close" flag (distinct from "back") in OOUI dialogs.
  • we consider adding a title to the icon only action
Jul 17 2019, 7:42 AM · Skipped QA, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), OOUI (OOUI-0.33.0), VisualEditor (Current work)

Jul 15 2019

Schnark added a comment to T228006: Inserting special character after link links that character, too.

This actually happens for all annotations:

  1. Place the cursor after a bold word.
  2. Switch bold off.
  3. Insert a special character.
Jul 15 2019, 10:02 AM · VisualEditor, VisualEditor-MediaWiki-Links
Schnark created T228006: Inserting special character after link links that character, too.
Jul 15 2019, 7:06 AM · VisualEditor, VisualEditor-MediaWiki-Links

Jul 9 2019

Schnark created T227564: Menu of DropdownWidget with $overlay has padding at bottom.
Jul 9 2019, 8:47 AM · OOUI

Jul 8 2019

Schnark added a comment to T225277: Save button on Special:Preferences lags behind when scrolling.

I reported the bug upstream as https://bugzilla.mozilla.org/show_bug.cgi?id=1564071

Jul 8 2019, 9:50 AM · OOUI, MediaWiki-User-preferences

Jul 4 2019

Schnark added a comment to T227254: Activity panel is shown three times in default dashboard on Phabricator frontpage.

The Activity Feed on the left is shown twice, too.

Jul 4 2019, 9:20 AM · WMSE-Bug-Reporting-and-Translation-2019, Phabricator

Jul 1 2019

Schnark added a comment to T226875: monobook skin "your alerts" click brings "your notices".

These changes improve things, but nonetheless, the personal menu is still broken in Monobook. To reproduce:

  1. Visit a wiki where the change is live already (e.g. beta.wmflabs), log in with a name that is not too short (since my name is quite short and shows the issues, you'll probably be able to verify them, too).
  2. Slowly decrease the width of the window and observe all the weirdness that happens:
Jul 1 2019, 10:28 AM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Growth-Team, MonoBook, Notifications

Jun 27 2019

Schnark updated subscribers of T226478: Syntaxhighlight in NWE out of sync when text contains TAB characters.

I suspect rGVEDc0799b060844: Source mode performance optimizations is shortcutting, and omits the whitespace replacements.

Jun 27 2019, 8:59 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), Regression, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor
Schnark added a project to T226478: Syntaxhighlight in NWE out of sync when text contains TAB characters: Regression.

Actually, CodeMirror still replaces TAB characters by arrows for display, via ve.ui.CodeMirrorAction.static.fixWhitespace. It's NWE that no longer does this replacement, so this must be a regression.

Jun 27 2019, 8:16 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), Regression, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor
Restricted Application added a project to T226692: Add mw-disambig class to original content in VE: VisualEditor.
Jun 27 2019, 7:48 AM · User-Ryasmeen, Parsoid, VisualEditor-MediaWiki-Links, VisualEditor, MediaWiki-extensions-Disambiguator

Jun 26 2019

Schnark added a comment to T226478: Syntaxhighlight in NWE out of sync when text contains TAB characters.

For reference, this is ve.visibleWhitespaceCharacters from ve.utils.js.

Jun 26 2019, 8:46 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), Regression, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor
Restricted Application added a project to T226604: After replacing last match, still one match shown: VisualEditor.
Jun 26 2019, 8:11 AM · Verified, VisualEditor (Current work), VisualEditor-EditingTools
Schnark added a comment to T226478: Syntaxhighlight in NWE out of sync when text contains TAB characters.

I just copied from a code file which had the code indented with tab characters. CodeEditor has nothing to do with it, this is about wikitext (which may contain code inside syntaxhighlight tags), not about real code.
No tool does or should replace anything during pasting, the pasted tab characters are still real tab characters. But VE and NWE display a tab character as arrow (just as VE displays a single line break as hooked arrow), which is shorter than the real tab character used by CodeMirror.

Jun 26 2019, 7:29 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), Regression, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor

Jun 25 2019

Restricted Application added projects to T226478: Syntaxhighlight in NWE out of sync when text contains TAB characters: VisualEditor, Community-Tech.
Jun 25 2019, 8:50 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work), Regression, MediaWiki-extensions-CodeMirror, VisualEditor-MediaWiki-2017WikitextEditor
Schnark created T226476: wgUserNewMsgRevisionId is null even when there are new messages.
Jun 25 2019, 8:27 AM · MediaWiki-General