Page MenuHomePhabricator

mmodell (Mukunda Modell)
Release Engineer, Phabricator AdminAdministrator

Projects (36)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Sep 19 2014, 9:45 AM (283 w, 3 d)
Roles
Administrator
Availability
Available
IRC Nick
twentyafterfour
LDAP User
20after4
MediaWiki User
MModell (WMF) [ Global Accounts ]

I am a Software Engineer on the Wikimedia Release-Engineering-Team.

What I do

Deployments

A big part of my work involves release automation and tooling. This includes Scap, Deployments, MediaWiki-Release-Tools and Train Deployments.

Phabricator

I am also responsible for Phabricator maintenance, improvements and occasional software deployments. I'm constantly working to improve phabricator through my contributions to Wikimedia-Phabricator-Extensions (rPHEX phabricator-extensions) and Phabricator (Upstream).

Elsewhere on the web:

github/20after4
Stack Overflow/20after4

Disclaimer: I work for the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.`

Recent Activity

Today

mmodell created P10500 extensions without codesniffer.
Mon, Feb 24, 4:48 PM · MediaWiki-Codesniffer

Fri, Feb 21

mmodell added a comment to T217008: Report results from SonarCloud to Gerrit.

@kostajh check out the "tag" field on https://gerrit.wikimedia.org/r/Documentation/rest-api-changes.html#comment-input - it appears you can tag comments with "autogenerated" and have them filterable, without actually using the half-baked "robot comments" feature.

Fri, Feb 21, 9:48 PM · Patch-For-Review, Continuous-Integration-Config, Code-Health-Metrics
mmodell added a comment to T244156: Make NDA task filing more obvious/prominent.

I guess I don't think we should further facilitate any "private" discussions in phabricator among arbitrary groups of users. Our guiding principles include Transparency. My understanding of that principle is that we do everything in public unless it would endanger the privacy of an individual or organization.

Fri, Feb 21, 7:17 PM · Security, Security-Team, Phabricator
mmodell added a comment to T244156: Make NDA task filing more obvious/prominent.

I'm not sure I understand what the use-case is. Why would a non-NDA user need to file an NDA task, and if they do, why should they be able to see it if they aren't under NDA. I can remove the NDA restriction on the NDA task form, without removing the restriction from the tasks created by that form. But I guess I want to understand the use case before I would make any changes.

Fri, Feb 21, 6:58 PM · Security, Security-Team, Phabricator
Aklapper awarded T222829: merge branch.py and make-wmf-branch a Like token.
Fri, Feb 21, 8:01 AM · Release-Engineering-Team (Deployment services), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Patch-For-Review, MediaWiki-Releasing (Workflow Improvements), MediaWiki-Release-Tools
mmodell closed T222829: merge branch.py and make-wmf-branch, a subtask of T196517: Automate weekly branch cut, as Resolved.
Fri, Feb 21, 3:07 AM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release-Engineering-Team (Deployment services), MediaWiki-Release-Tools
mmodell closed T222829: merge branch.py and make-wmf-branch, a subtask of T223392: Automate MediaWiki tarball release process, as Resolved.
Fri, Feb 21, 3:07 AM · MediaWiki-Release-Tools, MediaWiki-Releasing (Workflow Improvements), Epic
mmodell closed T222829: merge branch.py and make-wmf-branch as Resolved.
Fri, Feb 21, 3:06 AM · Release-Engineering-Team (Deployment services), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Patch-For-Review, MediaWiki-Releasing (Workflow Improvements), MediaWiki-Release-Tools
mmodell closed T113428: CentralNotice: make-wmf-branch doesn't work for named extension deployment branches, a subtask of T113731: [Task] make core wmf branches only use submodule branches that run with it in CI, as Resolved.
Fri, Feb 21, 2:39 AM · MediaWiki-Release-Tools, Continuous-Integration-Config, MediaWiki-extensions-CentralNotice, MediaWiki-extensions-Validator, Wikidata-Sprint-2015-09-29, Wikidata-Sprint-2015-09-15, Patch-For-Review, Wikidata
mmodell closed T113428: CentralNotice: make-wmf-branch doesn't work for named extension deployment branches as Resolved.

make-wmf-branch is no more. Marking resolved because I believe that the replacement for make-wmf-branch, branch.py, does create wmf/$version branches correctly for CentralNotice.

Fri, Feb 21, 2:39 AM · MediaWiki-Release-Tools, Fundraising-Backlog
mmodell closed T228658: make-wmf-branch should fail as soon as the first command fails as Declined.

Indeed, make-wmf-branch is no more.

Fri, Feb 21, 2:35 AM · Release-Engineering-Team (Deployment services), Release-Engineering-Team-TODO

Thu, Feb 20

mmodell added a hashtag to acl*security: #acl_security.
Thu, Feb 20, 7:50 PM
mmodell committed rPHEX0b765116eec0: Replace #security with #acl_security in instructional text (authored by mmodell).
Replace #security with #acl_security in instructional text
Thu, Feb 20, 7:50 PM
mmodell committed rPHEX2f36eee7ce67: Change #security project to #acl*security (authored by mmodell).
Change #security project to #acl*security
Thu, Feb 20, 7:38 PM
thcipriani awarded T222829: merge branch.py and make-wmf-branch a Love token.
Thu, Feb 20, 4:36 PM · Release-Engineering-Team (Deployment services), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Patch-For-Review, MediaWiki-Releasing (Workflow Improvements), MediaWiki-Release-Tools

Wed, Feb 19

mmodell changed the status of T215458: Convert zuul to use scap, a subtask of T224591: Migrate contint* hosts to Buster, from Open to Stalled.
Wed, Feb 19, 6:20 PM · Patch-For-Review, Release-Engineering-Team-TODO, Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure (phase-out-jessie), Operations
mmodell changed the status of T215458: Convert zuul to use scap from Open to Stalled.

blocked because I need to consult with @hashar before doing this

Wed, Feb 19, 6:19 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Continuous-Integration-Infrastructure (phase-out-jessie), Release-Engineering-Team (CI & Testing services), Patch-For-Review, Zuul

Fri, Feb 14

mmodell added a comment to T245201: Update protect as security issue to use acl*security.

@chasemp: The best way I can think of to make the transition easy (and ease future maintainability of the code) is to make the project names into config variables, then we can change the config (via web interface, not puppet) in sync with any changes to the actual project names.

Fri, Feb 14, 4:54 PM · Security, Phabricator, Security-Team

Thu, Feb 13

mmodell added a comment to T245201: Update protect as security issue to use acl*security.

@chasemp: Another thing to consider: phabricator spaces might be the more appropriate way to handle this now, rather than projects and acls.

Thu, Feb 13, 11:58 PM · Security, Phabricator, Security-Team
mmodell added a comment to T245201: Update protect as security issue to use acl*security.

btw: I really don't like the the acl* convention because it doesn't normalize consistently. I really don't see why we can't use only the icon as the indicator of ACL projects and then we won't need a naming convention.

Thu, Feb 13, 9:51 PM · Security, Phabricator, Security-Team
mmodell added a comment to T245201: Update protect as security issue to use acl*security.

WMFSecurityPolicy::getProjectByName uses the project name only and it will not match on hashtags. In fact, there isn't even a convenient mechanism to query by the Additional Hashtags field. I can change the code to use a different project name or I can switch it to use PHIDs, however, that has one drawback which is that it makes it more difficult for testing in other instances of phab where the PHIDs won't match.

Thu, Feb 13, 9:48 PM · Security, Phabricator, Security-Team
mmodell created Phatality.
Thu, Feb 13, 3:15 PM
mmodell archived Phabricator (2020-01-23).
Thu, Feb 13, 1:14 AM
mmodell created Phabricator (next).
Thu, Feb 13, 1:14 AM
mmodell renamed Phabricator (2020-02-13) from next to 2020-02-13.
Thu, Feb 13, 1:13 AM
mmodell committed rPHDEP7826f333ffb2: release/2020-02-12/1 (authored by mmodell).
release/2020-02-12/1
Thu, Feb 13, 12:56 AM

Wed, Feb 12

mmodell added a comment to T244566: Upgrade and restart m3 (phabricator) master (db1128).

@Marostegui Thursday 6:00 AM works for me.

Wed, Feb 12, 6:30 PM · Operations, DBA, Phabricator, Release-Engineering-Team (Development services)
mmodell moved T215458: Convert zuul to use scap from Maintenance to New Work on the Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)) board.
Wed, Feb 12, 6:10 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Continuous-Integration-Infrastructure (phase-out-jessie), Release-Engineering-Team (CI & Testing services), Patch-For-Review, Zuul
greg awarded T242446: Decide timing of the automatic mediawiki branch cut a Barnstar token.
Wed, Feb 12, 5:59 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Core Platform Team, Release-Engineering-Team (Deployment services), Goal
mmodell added a comment to T244566: Upgrade and restart m3 (phabricator) master (db1128).

Hey @Marostegui, How about tomorrow? I can be around tomorrow, if you'd like. If you'd like to do it at your leisure, and for future reference, the command for read-only is as follows:

Wed, Feb 12, 4:43 PM · Operations, DBA, Phabricator, Release-Engineering-Team (Development services)

Tue, Feb 11

mmodell changed the status of T13480: Immediately after deleting a talk page, the discussion / talk link at the top of the page will still show as blue, rather than as red. from Resolved to Declined.
Tue, Feb 11, 11:47 PM · MediaWiki-Special-pages
mmodell changed the status of T13476: Rename namespaces on Hungarian Wikipedia from Resolved to Invalid.
Tue, Feb 11, 11:46 PM · Wikimedia-Language-setup
mmodell added a comment to T218412: Define a mediawiki "version".

Kind of have a hard time imagining a situation where we actually want one or multiple appservers to serve something that is "just a little" different from all others but not completely. Not sure i understand why it's considered chaotic to have a single hash. Isn't it more chaotic to have subtle differences?

Tue, Feb 11, 10:00 PM · Release-Engineering-Team (Deployment services), Release-Engineering-Team-TODO, serviceops, Scap
mmodell committed rPHTR05f7cf9109aa: updated translations (authored by mmodell).
updated translations
Tue, Feb 11, 9:30 PM
mmodell committed rPHUTILb6f4e8e0f995: Merge remote-tracking branch 'upstream/stable' into wmf/stable (authored by mmodell).
Merge remote-tracking branch 'upstream/stable' into wmf/stable
Tue, Feb 11, 9:29 PM
mmodell committed rPHEX9ec849c6ea4a: Don't include security-team in the access list for security tasks (authored by mmodell).
Don't include security-team in the access list for security tasks
Tue, Feb 11, 9:29 PM
mmodell committed rPHDEPfb70a2166afe: preparing a release with changes to a bunch of submodules. (authored by mmodell).
preparing a release with changes to a bunch of submodules.
Tue, Feb 11, 8:56 PM

Mon, Feb 10

mmodell edited P10370 make-repo-readonly.sh.
Mon, Feb 10, 11:54 PM · Repository-Admins, Phabricator
mmodell edited P10370 make-repo-readonly.sh.
Mon, Feb 10, 11:30 PM · Repository-Admins, Phabricator
mmodell created P10370 make-repo-readonly.sh.
Mon, Feb 10, 11:27 PM · Repository-Admins, Phabricator
mmodell added a comment to T218412: Define a mediawiki "version".

it would be nice if the version information could be broken down in some way so that a small change to one file didn't radically alter the version. A hash of all file contents is unfortunately very chaotic and hard to reason about.. I'm thinking of something like what you get from git describe

Mon, Feb 10, 6:29 PM · Release-Engineering-Team (Deployment services), Release-Engineering-Team-TODO, serviceops, Scap
mmodell created T244772: PHP Notice: Undefined offset: 6 in extensions/JsonConfig/includes/JCTabularContentView.php.
Mon, Feb 10, 6:26 PM · Product-Infrastructure-Team-Backlog, JsonConfig, Wikimedia-production-error
mmodell changed the status of T233866: 1.35.0-wmf.18 deployment blockers from Stalled to Open.
Mon, Feb 10, 6:21 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release, Train Deployments
mmodell added a comment to T242023: Add alert for app servers in prod serving outdated MediaWiki branches.

Is it likely that there would be an update on the deploy server but not on the app servers for a long period of time?

Mon, Feb 10, 3:12 PM · observability, serviceops, Wikimedia-Incident
mmodell awarded T242023: Add alert for app servers in prod serving outdated MediaWiki branches a Yellow Medal token.
Mon, Feb 10, 3:05 PM · observability, serviceops, Wikimedia-Incident

Fri, Feb 7

mmodell added a comment to T240858: Clean up implementation for "follow" cases.

@awight: I can try to look on app servers to confirm what you're seeing. Which patch should be present?

Fri, Feb 7, 1:25 PM · WMDE-QWERTY-Sprint-2020-02-04, MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), WMDE-QWERTY-Sprint-2020-01-21, WMDE-QWERTY-Sprint-2020-01-08, User-notice, Patch-For-Review, Technical-Debt, Book-Referencing, Cite, WMDE-QWERTY-Sprint-2019-12-11

Thu, Feb 6

mmodell added a comment to T243848: Can't push to diffusion.

@MarcoAurelio can you try it with ssh:// instead of https://? I think that might prove more reliable.

Thu, Feb 6, 11:06 PM · Diffusion
mmodell triaged T244544: Add a quick rollback command to scap that skips all unnecessary steps as High priority.
Thu, Feb 6, 11:00 PM · Wikimedia-Incident, Scap
mmodell changed the status of T233866: 1.35.0-wmf.18 deployment blockers from Open to Stalled.
Thu, Feb 6, 10:45 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release, Train Deployments
mmodell moved T244544: Add a quick rollback command to scap that skips all unnecessary steps from On-going to Follow-up on the Wikimedia-Incident board.
Thu, Feb 6, 10:43 PM · Wikimedia-Incident, Scap
mmodell moved T244544: Add a quick rollback command to scap that skips all unnecessary steps from Needs triage to Debt on the Scap board.
Thu, Feb 6, 10:43 PM · Wikimedia-Incident, Scap
mmodell added a project to T244544: Add a quick rollback command to scap that skips all unnecessary steps: Wikimedia-Incident.
Thu, Feb 6, 10:42 PM · Wikimedia-Incident, Scap
mmodell added a parent task for T243009: Make scap skip restarting php-fpm when using --force: T244544: Add a quick rollback command to scap that skips all unnecessary steps.
Thu, Feb 6, 10:42 PM · Wikimedia-Incident, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release-Engineering-Team (Deployment services), Scap
mmodell added a subtask for T244544: Add a quick rollback command to scap that skips all unnecessary steps: T243009: Make scap skip restarting php-fpm when using --force.
Thu, Feb 6, 10:42 PM · Wikimedia-Incident, Scap
mmodell created T244544: Add a quick rollback command to scap that skips all unnecessary steps.
Thu, Feb 6, 10:41 PM · Wikimedia-Incident, Scap
mmodell added a comment to Blog Post: Why does building a skin require PHP knowledge?.

There are so many ways that MediaWiki shows it's age and skinning is definitely one of the most visible 😁

Thu, Feb 6, 10:27 AM · MediaWiki-Interface
mmodell awarded Blog Post: Why does building a skin require PHP knowledge? a Yellow Medal token.
Thu, Feb 6, 10:25 AM · MediaWiki-Interface

Wed, Feb 5

mmodell added a comment to T244405: PHP Notice: Undefined offset: 1 in ResourceLoaderSkinModule.php.

Thanks @matmarex, that does look like the likely culprit.

Wed, Feb 5, 9:08 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Performance-Team, MediaWiki-ResourceLoader, Wikimedia-production-error
mmodell added a comment to T244405: PHP Notice: Undefined offset: 1 in ResourceLoaderSkinModule.php.

Happening only in group1 wikis

Wed, Feb 5, 9:05 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Performance-Team, MediaWiki-ResourceLoader, Wikimedia-production-error
mmodell added a project to T244405: PHP Notice: Undefined offset: 1 in ResourceLoaderSkinModule.php: MediaWiki-ResourceLoader.
Wed, Feb 5, 9:04 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Performance-Team, MediaWiki-ResourceLoader, Wikimedia-production-error
mmodell updated the task description for T244405: PHP Notice: Undefined offset: 1 in ResourceLoaderSkinModule.php.
Wed, Feb 5, 8:49 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Performance-Team, MediaWiki-ResourceLoader, Wikimedia-production-error
mmodell created T244405: PHP Notice: Undefined offset: 1 in ResourceLoaderSkinModule.php.
Wed, Feb 5, 8:48 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Performance-Team, MediaWiki-ResourceLoader, Wikimedia-production-error
mmodell added a comment to T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207.

The problem seems to persist on beta.

Wed, Feb 5, 6:46 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-General, Wikimedia-production-error
mmodell added a comment to T233866: 1.35.0-wmf.18 deployment blockers.

Train status: Unblocked. The train will move forward, at least until there is more evidence for production impact or other serious fallout from T244300.

Wed, Feb 5, 6:39 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release, Train Deployments
mmodell added a comment to T244019: Inconsistent user permissions for users who were recently added to a new group.

I'm gonna make the call that this isn't serious enough to block the train _yet_ at least not without further evidence that it's affecting production. So I think we will cautiously move forward with the train while monitoring this for further fallout/production impact.

Wed, Feb 5, 6:32 PM · MediaWiki-User-management
mmodell raised the priority of T215458: Convert zuul to use scap from Medium to High.
Wed, Feb 5, 6:28 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Continuous-Integration-Infrastructure (phase-out-jessie), Release-Engineering-Team (CI & Testing services), Patch-For-Review, Zuul
mmodell added a comment to T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207.

Should we roll back group0 due to the disruption this is causing? The error rate is surprisingly high for code that's only deployed to group0.

Wed, Feb 5, 12:15 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-General, Wikimedia-production-error

Tue, Feb 4

mmodell merged task T244299: Special:MyLanguage throws TypeError into T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207.
Tue, Feb 4, 10:46 PM · Wikimedia-production-error, MediaWiki-General
mmodell merged T244299: Special:MyLanguage throws TypeError into T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207.
Tue, Feb 4, 10:46 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-General, Wikimedia-production-error
mmodell created T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207.
Tue, Feb 4, 10:44 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-General, Wikimedia-production-error
mmodell added a comment to T244019: Inconsistent user permissions for users who were recently added to a new group.

What's the current status of this? Is this still a train blocker?

Tue, Feb 4, 9:49 PM · MediaWiki-User-management
mmodell added a comment to T233866: 1.35.0-wmf.18 deployment blockers.

branch cut for wmf.18: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/570138

Tue, Feb 4, 8:47 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release, Train Deployments

Sat, Feb 1

Siddikbabu awarded Blog Post: Phabricator Status Update a Stroopwafel token.
Sat, Feb 1, 8:14 PM · Release-Engineering-Team, Phabricator

Thu, Jan 30

mmodell added a comment to T238593: Phabricator downtime due to aphlict and websockets (aphlict current disabled).

why are there 2 yaml files for apache traffic server

  • backend.yaml 22280
  • tls.yaml
  • what is port 3120
  • protocol is wss://
  • acme cert
Thu, Jan 30, 11:40 PM · Patch-For-Review, Phabricator, serviceops, Operations, Traffic, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3))

Tue, Jan 28

mmodell added a comment to T215458: Convert zuul to use scap.

Sorry @Paladox, not meaning to step on your toes here but I am assigned to move this forward.

Tue, Jan 28, 10:31 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Continuous-Integration-Infrastructure (phase-out-jessie), Release-Engineering-Team (CI & Testing services), Patch-For-Review, Zuul
mmodell claimed T215458: Convert zuul to use scap.
Tue, Jan 28, 10:26 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Continuous-Integration-Infrastructure (phase-out-jessie), Release-Engineering-Team (CI & Testing services), Patch-For-Review, Zuul

Jan 23 2020

mmodell edited projects for T243247: Need to force users to reset their phabricator TOTP auth factor, added: Phabricator (2020-01-23); removed Phabricator.
Jan 23 2020, 5:06 PM · Security, Phabricator (2020-01-23), Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Security-Team
mmodell edited projects for T224082: No results for specific string in Global Phab Search, while Advanced Search lists expected results (due to ElasticSearch for Global Search vs Ferret for Maniphest Search)?, added: Phabricator (2020-01-23); removed Phabricator.
Jan 23 2020, 5:06 PM · Phabricator (2020-01-23)
mmodell edited projects for T243479: Phab Global Search broken: Unhandled Exception: Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object given, added: Phabricator (2020-01-23); removed Phabricator.
Jan 23 2020, 5:03 PM · Phabricator (2020-01-23), Regression
mmodell closed T224082: No results for specific string in Global Phab Search, while Advanced Search lists expected results (due to ElasticSearch for Global Search vs Ferret for Maniphest Search)? as Resolved.

This specific issue is resolved by escaping the backslash in the elasticsearch storage engine. I intend to revisit this as it looks like ferret is the right choice going forward. Thanks to @epriestley for the valuable feedback on this! It really is appreciated.

Jan 23 2020, 4:58 PM · Phabricator (2020-01-23)
mmodell changed the visibility for T243247: Need to force users to reset their phabricator TOTP auth factor.
Jan 23 2020, 4:53 PM · Security, Phabricator (2020-01-23), Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Security-Team
mmodell closed T243479: Phab Global Search broken: Unhandled Exception: Argument 1 passed to PhabricatorHandleQuery::withPHIDs() must be of the type array, object given as Resolved by committing rPHAB8a99d78f5b88: Move the construction of PhabricatorFulltextResultSet into the Fulltext Storage….
Jan 23 2020, 12:29 PM · Phabricator (2020-01-23), Regression
mmodell closed T242018: Make ‘Protect as security issue’ add project #security-team as Resolved.
Jan 23 2020, 1:30 AM · Phabricator (2020-01-23), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Security-Team
mmodell archived Phabricator (2019-12-19).
Jan 23 2020, 1:29 AM
mmodell created Phabricator (2020-02-13).
Jan 23 2020, 1:19 AM
mmodell renamed Phabricator (2020-01-23) from Next to 2020-01-23.
Jan 23 2020, 1:18 AM
mmodell committed rPHDEPc869c551601e: updated submodules (authored by mmodell).
updated submodules
Jan 23 2020, 1:16 AM
mmodell committed rPHTR036c92cc1434: Updated translations. (authored by mmodell).
Updated translations.
Jan 23 2020, 1:12 AM
mmodell closed T243247: Need to force users to reset their phabricator TOTP auth factor as Resolved by committing rPHAB2785d6a8b210: WMF Hack: Prompt to replace auth factors from before August 2019.
Jan 23 2020, 1:10 AM · Security, Phabricator (2020-01-23), Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Security-Team

Jan 22 2020

mmodell committed rPHAVAd3f5a1c67bb4: Antivandalism extension initial public release. (authored by mmodell).
Antivandalism extension initial public release.
Jan 22 2020, 10:12 PM
mmodell added a comment to T242898: Mirroring Diffusion repositories to GitHub seems to be broken.

@bd808: one solution would be to switch it to use https authentication with a github token. I can probably whip up a quick automation to update all of the repositories via the conduit api rather than manually updating them. Can you set up the credentials on github and passphrase?

Jan 22 2020, 9:39 PM · Phabricator, Tools, Toolforge, cloud-services-team (Kanban), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Diffusion
mmodell updated subscribers of T242898: Mirroring Diffusion repositories to GitHub seems to be broken.
ssh: connect to host github.com port 22: Connection timed out
      fatal: Could not read from remote repository.
Jan 22 2020, 9:31 PM · Phabricator, Tools, Toolforge, cloud-services-team (Kanban), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Diffusion
mmodell moved T243247: Need to force users to reset their phabricator TOTP auth factor from INBOX to New Work on the Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)) board.
Jan 22 2020, 6:17 PM · Security, Phabricator (2020-01-23), Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Security-Team
mmodell added a project to T242018: Make ‘Protect as security issue’ add project #security-team: Phabricator.
Jan 22 2020, 6:15 PM · Phabricator (2020-01-23), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Security-Team
mmodell changed the status of T181393: Make sure elasticsearch 6 is supported in phabricator, a subtask of T194199: [Epic] Prepare for Elasticsearch 6 upgrade, from Open to Stalled.
Jan 22 2020, 6:13 PM · Discovery-Search, Epic
mmodell changed the status of T181393: Make sure elasticsearch 6 is supported in phabricator from Open to Stalled.
Jan 22 2020, 6:13 PM · User-MModell, Phabricator, Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3))
mmodell added a project to T243247: Need to force users to reset their phabricator TOTP auth factor: Phabricator.
Jan 22 2020, 6:11 PM · Security, Phabricator (2020-01-23), Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Security-Team
mmodell added a comment to T243247: Need to force users to reset their phabricator TOTP auth factor.

@Dsharpe I was planning to deploy this today along with a lot of other stuff that's been backing up in my undeployed queue. Do you really think it should wait for ~2 weeks?

Jan 22 2020, 6:10 PM · Security, Phabricator (2020-01-23), Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Security-Team

Jan 21 2020

mmodell added a comment to T243247: Need to force users to reset their phabricator TOTP auth factor.

Ok so I've got everything ready to deploy. Should I request a dedicated deployment window for this?

Jan 21 2020, 9:34 PM · Security, Phabricator (2020-01-23), Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Security-Team
mmodell updated the task description for T243247: Need to force users to reset their phabricator TOTP auth factor.
Jan 21 2020, 9:26 PM · Security, Phabricator (2020-01-23), Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Security-Team